if no header defined should return null #12189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isset($req->getHeaders()[ 'abc' ]) To null !== $req->getHeader('abc')
|
what's wrong with AppVeyor? .. |
|
How about: if (!$req->getHeader('abc')) {
// ...
}Right now it works so. |
|
@sergeyklay yes! introducing hasHeader is better than changing the current API :) 👍 |
|
@tkaven Could you please rebase onto 3.1.x branch |
sergeyklay
force-pushed
the
3.1.x
branch
14 times, most recently
from
4981aa0
to
a848621
Compare
sergeyklay
force-pushed
the
3.1.x
branch
2 times, most recently
from
4d3c73f
to
6ef079c
Compare
|
@tkaven ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isset($req->getHeaders()[ 'abc' ]) To null !== $req->getHeader('abc')